Page MenuHomePhabricator

Add hello/email banner, add telemetry banner, add whitelisted function list to code + docs, make telemetry opt-out

Authored by catherinewu on Mar 24 2020, 8:18 AM.

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

catherinewu created this revision.


Harbormaster failed remote builds in B8843: Diff 10933!

check TTY before prompting user for email

I'm not sure whether we should keep the add_email endpoint in the subdomain ''

To avoid creating a new service, we could move/rename

'' => ''
'' => ''

verified that sys.stdout.isatty() and sys.stdin.isatty()are both false when run from within a docker container

schrockn requested changes to this revision.Mar 30 2020, 10:43 PM
schrockn added inline comments.

let's do a hard failure here. otherwise people will add telemetry decorator and be very confused as to why it is not working

This revision now requires changes to proceed.Mar 30 2020, 10:43 PM
schrockn accepted this revision.Mar 31 2020, 11:25 PM
This revision is now accepted and ready to land.Mar 31 2020, 11:25 PM
catherinewu updated this revision to Diff 11382.Apr 3 2020, 4:56 PM

fix import