Page MenuHomePhabricator

#2296 add dagster/parent_run_id tag when re-execution
ClosedPublic

Authored by yuhan on Mon, Mar 23, 5:36 PM.

Details

Summary
Test Plan
  • BK
  • dagit showed parent_run_id on runtable
  • PipelineRun in dagster.core.storage received the dagster/parent_run_id tag
> /Users/yuhan/dev/dagster/python_modules/dagster/dagster/core/storage/pipeline_run.py(92)__new__()
     91         ipdb.set_trace()
---> 92         return super(PipelineRun, cls).__new__(
     93             cls,

ipdb> tags
{'dagster/parent_run_id': 'b5bbb1cd-154c-4a68-92db-691f8fde3890'}

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuhan created this revision.Mon, Mar 23, 5:36 PM
yuhan edited the summary of this revision. (Show Details)Mon, Mar 23, 5:45 PM
max accepted this revision.Mon, Mar 23, 6:25 PM
max added a subscriber: alangenfeld.

I think we need to update a snapshot test but this looks great.

js_modules/dagit/src/runs/Run.tsx
154

reexecutionTag

163–164

@alangenfeld can you explain why only on full retry/resume-retry?

168

reexecutionTag

This revision is now accepted and ready to land.Mon, Mar 23, 6:25 PM
alangenfeld added inline comments.Mon, Mar 23, 6:26 PM
js_modules/dagit/src/runs/Run.tsx
163–164

not confident that all tags should be copied over for single step re-execution so just opted out for now.

For example i dont think we want single step debug runs to show up in partition set queries

yuhan marked 2 inline comments as done.Mon, Mar 23, 8:34 PM
yuhan added inline comments.
js_modules/dagit/src/runs/Run.tsx
163–164

I'm gonna only add the parent_run_id here because this is the very first pass to support run grouping. pretty sure it will change in a very short term

yuhan edited the summary of this revision. (Show Details)Mon, Mar 23, 8:39 PM
yuhan edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
alangenfeld added inline comments.Tue, Mar 24, 11:41 PM
js_modules/dagit/src/runs/Run.tsx
168

push returns the length of the new length of the mutated in place list, not the updated list