Page MenuHomePhabricator

[dagster-aws] Improve test coverage
ClosedPublic

Authored by nate on Sat, Mar 21, 6:18 PM.

Details

Summary

also added a few missing version tests

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Sat, Mar 21, 6:18 PM
nate edited the summary of this revision. (Show Details)Sat, Mar 21, 10:45 PM
nate added reviewers: max, schrockn.
max accepted this revision.Mon, Mar 23, 6:21 PM

Thank you!! ๐Ÿ™

python_modules/libraries/dagster-aws/dagster_aws/cloudwatch/loggers.py
192โ€“224

We should figure out some convention or tooling to help us doc these objects' config

196

even better if this could be a literal include

This revision is now accepted and ready to land.Mon, Mar 23, 6:21 PM
nate added inline comments.Mon, Mar 23, 6:25 PM
python_modules/libraries/dagster-aws/dagster_aws/cloudwatch/loggers.py
196

yeah agree! I filed https://github.com/dagster-io/dagster/issues/2311 - will do this as a followup as one pass over the docs because (1) we have a bunch of these, and (2) would be good to standardize on convention re: where we stash these examples

This revision was automatically updated to reflect the committed changes.