Page MenuHomePhabricator

Add a dagster pipeline launch command
ClosedPublic

Authored by max on Mar 21 2020, 2:35 AM.

Diff Detail

Repository
R1 dagster
Branch
dagster-pipeline-launch
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Mar 21 2020, 2:35 AM
max updated this revision to Diff 10788.Mar 21 2020, 3:11 AM

preset_name

nate accepted this revision.Mar 21 2020, 3:40 PM
nate added a subscriber: nate.

Adding two feedback notes from Ken on Slack—otherwise LGTM!

python_modules/dagster/dagster/cli/pipeline.py
43–45

Add group.add_command(pipeline_launch_command)

351

should be get_pipeline_instructions('launch')

This revision is now accepted and ready to land.Mar 21 2020, 3:40 PM

picard_clap

python_modules/dagster/dagster/cli/pipeline.py
413

hows the error if you don't have a run launcher set? may want to do a proactive check if its bad

This revision was automatically updated to reflect the committed changes.