Page MenuHomePhabricator

Make Celery configs Noneable
ClosedPublic

Authored by nate on Wed, Mar 18, 4:07 AM.

Details

Summary

Fixes #2289

@max seems like most of the CLI tests are marked as @skip_ci so I didn't add one for these changes, but let me know if there's a good way to test this behavior besides manually invoking

Test Plan

tested against example in github issue

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate updated this revision to Diff 10656.Wed, Mar 18, 4:07 AM
nate created this revision.

up

nate edited the summary of this revision. (Show Details)Wed, Mar 18, 4:09 AM
nate added a reviewer: max.
nate added a subscriber: max.
max added a comment.Wed, Mar 18, 6:56 PM

Hmm, let's add a test anyway? Those tests run locally.

max accepted this revision.Wed, Mar 18, 6:57 PM
This revision is now accepted and ready to land.Wed, Mar 18, 6:57 PM
This revision was automatically updated to reflect the committed changes.