Page MenuHomePhabricator

document & export SolidExecutionContext
ClosedPublic

Authored by alangenfeld on Mar 17 2020, 7:26 PM.

Details

Summary

SystemComputeExecutionContext which we previously exported was not the one actually threaded to users

worth discussing: renaming this to SolidContext instead since we hadn't previously exported it

Test Plan

eyes

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Mar 17 2020, 7:26 PM
alangenfeld added inline comments.Mar 17 2020, 7:27 PM
docs/sections/api/apidocs/execution.rst
30–34

:inherited-members: doesn't work here since [1]

python_modules/dagster/dagster/core/execution/context/compute.py
47–58

[1] we do this multiple inheritance shenanigans

prha added inline comments.Mar 17 2020, 7:44 PM
python_modules/dagster/dagster/core/execution/context/compute.py
47–49

SolidExecutionContext?

52

did not realize we do this wrapping...

alangenfeld added inline comments.Mar 17 2020, 7:45 PM
python_modules/dagster/dagster/core/execution/context/compute.py
52

i think its crazy hook jumping to make dagstermill work

schrockn added inline comments.Mar 17 2020, 9:04 PM
python_modules/dagster/dagster/core/execution/context/compute.py
52

The wrapping is for encapsulation. This means that properties available to the user-facing context are whitelisted so that we if add internal things users can't access them by default.

I'm open to reconsidering that decision

schrockn requested changes to this revision.Mar 18 2020, 7:33 PM

i like the idea of renaming it per @prha 's suggestion

python_modules/dagster/dagster/core/execution/context/compute.py
47–49

👍🏻

This revision now requires changes to proceed.Mar 18 2020, 7:33 PM
alangenfeld retitled this revision from document & export ComputeExecutionContext to document & export SolidExecutionContext.Mar 19 2020, 6:07 PM
This revision is now accepted and ready to land.Mar 19 2020, 6:21 PM
This revision was automatically updated to reflect the committed changes.