Update contributing to indicate pre-commit is optional
ClosedPublic
Actions

Authored by • schrockn on Apr 29 2019, 6:02 PM.

Tags

None

Referenced Files

	F2900009: D21.diff
	Fri, Mar 31, 3:01 AM

	Unknown Object (File)
	Wed, Mar 29, 11:06 AM

	Unknown Object (File)
	Wed, Mar 22, 8:49 PM

	Unknown Object (File)
	Tue, Mar 14, 4:56 PM

	Unknown Object (File)
	Sun, Mar 12, 7:35 AM

	Unknown Object (File)
	Fri, Mar 10, 12:55 PM

	Unknown Object (File)
	Feb 19 2023, 11:29 PM

	Unknown Object (File)
	Feb 10 2023, 9:50 AM

View All 61 Files

Subscribers

None

Details

Reviewers

• max
alangenfeld

Commits

R1:3f5ce67079a5: Update contributing to indicate pre-commit is optional

Summary

Pre-commit not a hard requirement

Test Plan

unit tests

Diff Detail

Repository

R1 dagster

Branch

fix-contributing

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• schrockn created this revision.Apr 29 2019, 6:02 PM

rebase

Harbormaster failed remote builds in B96: Diff 110!Apr 29 2019, 6:08 PM

Harbormaster completed remote builds in B97: Diff 112.Apr 29 2019, 6:14 PM

• schrockn added a reviewer: alangenfeld.Apr 29 2019, 6:56 PM

alangenfeld accepted this revision.Apr 29 2019, 7:28 PM

This revision is now accepted and ready to land.Apr 29 2019, 7:28 PM

Closed by commit R1:3f5ce67079a5: Update contributing to indicate pre-commit is optional (authored by • schrockn). · Explain WhyApr 29 2019, 7:28 PM

This revision was automatically updated to reflect the committed changes.

• jordansanders mentioned this in D8684: style: adopt pre-commit for Python black formatting.Jul 6 2021, 7:07 PM

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

docs/

sections/

community/

contributing.rst

10 lines

snapshots/

snap_test_doc_build.py

17 lines

Diff 112

View Options

python_modules/dagster/docs/sections/community/contributing.rst