Page MenuHomePhabricator

[tox] fix local install check
ClosedPublic

Authored by alangenfeld on Feb 26 2020, 6:54 PM.

Details

Summary

D1390 accidentally just turned off the check everywhere - so a handful of prod module use had crept in.

This introduces unix/windows variance to the tox envs so we can use that to gate things.

Test Plan

buildkite and azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Feb 26 2020, 6:54 PM

fix tox fiels

alangenfeld edited the summary of this revision. (Show Details)Feb 26 2020, 11:58 PM
alangenfeld edited the test plan for this revision. (Show Details)
alangenfeld added reviewers: max, nate, prha.
prha accepted this revision.Feb 27 2020, 12:14 AM
prha added inline comments.
azure-pipelines.yml
8

👍

This revision is now accepted and ready to land.Feb 27 2020, 12:14 AM
nate accepted this revision.Feb 27 2020, 3:48 AM

clint_eastwood

examples/airline.tox
7

ughhh this happens too often for comfort

This revision was automatically updated to reflect the committed changes.