Page MenuHomePhabricator

Fix bug in config post-processing

Authored by nate on Feb 14 2020, 10:40 PM.



typo - result has no "error" property, its "errors" which is a list of errors that needs to be flattened.

Hit this in Helm chart testing

Test Plan


Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Feb 14 2020, 10:40 PM
nate edited the summary of this revision. (Show Details)Feb 14 2020, 10:42 PM
nate added reviewers: alangenfeld, max.
max added a comment.Feb 14 2020, 10:47 PM

Can we add a test also!

alangenfeld accepted this revision.Feb 14 2020, 10:48 PM

nice good catch

should be easy to sneak a test in to python_modules/dagster/dagster_tests/core_tests/config_types_tests/

This revision is now accepted and ready to land.Feb 14 2020, 10:48 PM
This revision was automatically updated to reflect the committed changes.