Page MenuHomePhabricator

use source import from dagster.seven
ClosedPublic

Authored by alangenfeld on Feb 13 2020, 6:28 PM.

Details

Summary

had to update the function to get it to pass our test suite

Test Plan

existing tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Feb 13 2020, 6:28 PM
alangenfeld added inline comments.Feb 13 2020, 6:36 PM
python_modules/dagster/dagster/seven/__init__.py
67–73

this is the behavior these others* seem to have based on tests (and commenting out code)

77

*

81

*

prha accepted this revision.Feb 13 2020, 6:37 PM
prha added inline comments.
python_modules/dagster/dagster/seven/__init__.py
67–72

good catch

This revision is now accepted and ready to land.Feb 13 2020, 6:37 PM
This revision was automatically updated to reflect the committed changes.