Page MenuHomePhabricator

make all run buttons launch enabled
ClosedPublic

Authored by prha on Feb 12 2020, 10:26 PM.

Details

Summary

This diff extracts out a new component LaunchButtonGroup, which takes
two child components, and toggles them based on the execute/launch menu option.

This diff does not vary the menu text, which always displays execute vs launch.

We refactored the Run.tsx so that we could pull out distinct onExecute and
onLaunch functions, to render distinct buttons with the same arguments.

Test Plan

used launcher, saw launch mutation fired

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Feb 12 2020, 10:26 PM
prha updated this revision to Diff 9631.Feb 12 2020, 10:51 PM

add syncing hack using useState

alangenfeld added inline comments.Feb 12 2020, 10:54 PM
js_modules/dagit/src/execute/PipelineExecutionButtonGroup.tsx
77–89

what are these less-good tooltips and stuff doing around?

This revision is now accepted and ready to land.Feb 12 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.