Page MenuHomePhabricator

[dagit] handle errors in DirectGraphQLSubscription
ClosedPublic

Authored by alangenfeld on Wed, Feb 12, 9:47 PM.

Details

Test Plan

caused errors in compute and even log subscriptions - verified toast prompted and uis rendered in to a ... reasonable state

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Wed, Feb 12, 9:47 PM
alangenfeld updated this revision to Diff 9618.Wed, Feb 12, 9:51 PM

issue # + rm debug

prha added inline comments.Wed, Feb 12, 9:58 PM
js_modules/dagit/src/DirectGraphQLSubscription.ts
104

remove

bengotow accepted this revision.Wed, Feb 12, 10:45 PM

Accepted with one minor nit!

js_modules/dagit/src/DirectGraphQLSubscription.ts
93

I think we can swap this out for errors.forEach both here and above on line 32 of the previous file since showGraphQLError does not return anything. The map function is usually used when you want to collect the results into an array for display / processing.

python_modules/dagster-graphql/dagster_graphql/schema/runs.py
817

๐Ÿ‘

This revision is now accepted and ready to land.Wed, Feb 12, 10:45 PM

handle the empty case better

prha added inline comments.Wed, Feb 12, 10:54 PM
js_modules/dagit/src/runs/ComputeLogContent.tsx
171

remove?

This revision was automatically updated to reflect the committed changes.