Page MenuHomePhabricator

Helm values.yaml rename job_image -> job_runner
ClosedPublic

Authored by nate on Wed, Feb 12, 8:33 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Wed, Feb 12, 8:33 PM
alangenfeld accepted this revision.Wed, Feb 12, 8:45 PM

check k8s.rst as well but p sure thats fine

This revision is now accepted and ready to land.Wed, Feb 12, 8:45 PM
nate updated this revision to Diff 9609.Wed, Feb 12, 8:56 PM

update readme also

nate added a comment.Wed, Feb 12, 8:57 PM

cool, did a scan through and I think that's all. it's a little wonky that the run launcher takes job_image while this has separate repo and tag fields, but that's a problem for later

This revision was automatically updated to reflect the committed changes.