Page MenuHomePhabricator

Use local artifacts storage for Scheduler
ClosedPublic

Authored by sashank on Feb 12 2020, 6:57 PM.

Details

Summary

Remove artifacts_dir from SystemCronScheduler, and rely on local artifacts storage instead.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Feb 12 2020, 6:57 PM
alangenfeld requested changes to this revision.Feb 12 2020, 6:59 PM

k8s is gonna break - also make sure no docs or comments refer to it if we're dropping it

This revision now requires changes to proceed.Feb 12 2020, 6:59 PM

otherwise code looks good

sashank updated this revision to Diff 9594.Feb 12 2020, 7:01 PM

Fix k8s and remove mentions of artifacts_dir from docs

sashank updated this revision to Diff 9596.Feb 12 2020, 7:05 PM

Fix tests

sashank updated this revision to Diff 9597.Feb 12 2020, 7:14 PM

Fix more tests

alangenfeld accepted this revision.EditedFeb 12 2020, 7:15 PM

config: {} is strange(invalid?) yaml - should just be config: but hopefully you can just omit the key all together

CHANGES.md
31–32

can you omit config all together?

This revision is now accepted and ready to land.Feb 12 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.