Page MenuHomePhabricator

Per live discussions, remove usable types from libraries (Verbose bay bikes version)

Authored by schrockn on Feb 11 2020, 11:41 PM.



This is the version without the mapping

We are pushing users to scope these mappings
to their projects instead of libraries.

I did take my a couple times to get this right and
put the mapping call in the right spot, so there's that.

Test Plan


Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Feb 11 2020, 11:41 PM

This was thrown up as an alternative/basis of discussion on


also can use dagster_pandas.DataFrame throughout...

schrockn updated this revision to Diff 9558.Feb 11 2020, 11:54 PM

spin tests

alangenfeld accepted this revision.Feb 12 2020, 1:55 AM
This revision is now accepted and ready to land.Feb 12 2020, 1:55 AM

let's sleep on it and I think @themissinghlink wanted to stew on it a bit

ya no rush - just accepted based on my comment on D1996 for reference

@alangenfeld do you think we should change the airline_demo to be the verbose variant as well

in the spirit of having one diff that demonstrates "heres why mapping can be useful" I think thats probably a good exercise but be judicious with your time