Page MenuHomePhabricator

cascade run deletions in postgres
ClosedPublic

Authored by prha on Mon, Feb 10, 9:32 PM.

Details

Summary

will require folks to run dagster instance migrate to pick up the cascade deletion.

Test Plan

ran test suite, deletion with tags

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Mon, Feb 10, 9:32 PM
prha updated this revision to Diff 9467.Mon, Feb 10, 10:10 PM

update to sync event_storage, run_storage migration scripts

prha edited the summary of this revision. (Show Details)Mon, Feb 10, 10:20 PM
prha added reviewers: sashank, max.
max accepted this revision.Mon, Feb 10, 11:30 PM
This revision is now accepted and ready to land.Mon, Feb 10, 11:30 PM
max added inline comments.Mon, Feb 10, 11:31 PM
python_modules/dagster/dagster/utils/test/run_storage.py
433

can we add an assertion that the entries in the tags tables are gone too

prha updated this revision to Diff 9482.Tue, Feb 11, 12:27 AM

assert empty run tags

prha updated this revision to Diff 9487.Tue, Feb 11, 12:42 AM

resolve conflicting tag issues

prha planned changes to this revision.Tue, Feb 11, 12:53 AM

Need to fix the other RunStorage implementations...

python_modules/dagster/dagster/utils/test/run_storage.py
433

yup, good idea....

prha updated this revision to Diff 9511.Tue, Feb 11, 6:25 PM
  • add in memory, sqlite storage impl
This revision is now accepted and ready to land.Tue, Feb 11, 6:25 PM
This revision was automatically updated to reflect the committed changes.