Page MenuHomePhabricator

fix graphql log message
ClosedPublic

Authored by alangenfeld on Feb 7 2020, 10:43 PM.

Details

Summary

The GraphQL interface says this should not be null - so don't set it to None

Test Plan

existing snapshot tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Feb 7 2020, 10:43 PM
schrockn accepted this revision.Feb 7 2020, 10:47 PM

oy. is there a test to exercise this codepath?

This revision is now accepted and ready to land.Feb 7 2020, 10:47 PM

I assumed coverage but let me actually verify

alangenfeld updated this revision to Diff 9435.Feb 10 2020, 4:30 PM

rebase on snapshot tests

schrockn accepted this revision.Feb 10 2020, 4:32 PM

Merge pending test coverage verification

This revision was automatically updated to reflect the committed changes.