Page MenuHomePhabricator

Use startPipelineExecution for K8sRunLauncher
ClosedPublic

Authored by max on Jan 23 2020, 11:45 PM.

Details

Summary

Fixes an issue where the pipeline events were not being generated.

Test Plan

Unit & manual acceptance

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Jan 23 2020, 11:45 PM
alangenfeld added inline comments.Jan 23 2020, 11:56 PM
python_modules/dagster/dagster/core/instance/__init__.py
306–311

this should probably be a proper Dagster__Error with message about accidental ID re-use? I think thats the most likely failure case

alangenfeld accepted this revision.Jan 23 2020, 11:57 PM

think its worth improving the error but otherwise i think this is good

This revision is now accepted and ready to land.Jan 23 2020, 11:57 PM
max updated this revision to Diff 8955.Mon, Jan 27, 9:26 PM

Rebase

max updated this revision to Diff 8957.Mon, Jan 27, 9:28 PM

New error class

Harbormaster failed remote builds in B7274: Diff 8957!
max updated this revision to Diff 8969.Mon, Jan 27, 9:51 PM

Fixup test specs

max updated this revision to Diff 8979.Mon, Jan 27, 10:34 PM

Fixup

max updated this revision to Diff 8980.Mon, Jan 27, 10:36 PM

Fixup

Harbormaster completed remote builds in B7297: Diff 8980.
This revision was automatically updated to reflect the committed changes.