Page MenuHomePhabricator

(2/n scheduler-refactor) Remove status argument from all schedule methods
ClosedPublic

Authored by sashank on Jan 23 2020, 10:20 PM.

Details

Summary

This is a small change to the scheduler API to make it simpler and help separate the scheduler from schedule storage.

This diff simply removes the status filter argument on scheduler methods, and instead requires the caller of the method to do the filter instead.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Jan 23 2020, 10:20 PM
sashank retitled this revision from Remove status argument from methods to Remove status argument from schedule methods.Fri, Jan 24, 8:41 PM
sashank retitled this revision from Remove status argument from schedule methods to (2/n scheduler-refactor) Remove status argument from all schedule methods.Wed, Jan 29, 1:10 AM
sashank edited the summary of this revision. (Show Details)Thu, Jan 30, 11:29 PM
sashank added reviewers: alangenfeld, prha.
prha accepted this revision.Thu, Jan 30, 11:59 PM
This revision is now accepted and ready to land.Thu, Jan 30, 11:59 PM
sashank updated this revision to Diff 9298.Wed, Feb 5, 10:20 PM
sashank edited the summary of this revision. (Show Details)

rebase