Page MenuHomePhabricator

[codemod] yaml.load -> yaml.safe_load
ClosedPublic

Authored by alangenfeld on Jan 17 2020, 8:17 PM.

Details

Summary

try again to do PR#2051 which had some CI issues

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jan 17 2020, 8:17 PM
schrockn requested changes to this revision.Jan 21 2020, 2:23 AM

seems fine, although isn't this a slightly different fix than the warning text indicates?

python_modules/dagster/dagster/core/serdes/__init__.py
197

what's this all about?

This revision now requires changes to proceed.Jan 21 2020, 2:23 AM

seems fine, although isn't this a slightly different fix than the warning text indicates?

yep see https://github.com/dagster-io/dagster/pull/2051#discussion_r364961206

python_modules/dagster/dagster/core/serdes/__init__.py
197

debugging buildkite failures

alangenfeld updated this revision to Diff 8781.Tue, Jan 21, 3:44 PM

remove debug

schrockn accepted this revision.Tue, Jan 21, 4:03 PM

cool thx for link

This revision is now accepted and ready to land.Tue, Jan 21, 4:03 PM
alangenfeld updated this revision to Diff 8782.Tue, Jan 21, 4:28 PM

back to debugging

alangenfeld updated this revision to Diff 8783.Tue, Jan 21, 5:05 PM

more debug

alangenfeld updated this revision to Diff 8784.Tue, Jan 21, 9:32 PM

apply workaround

alangenfeld added inline comments.Tue, Jan 21, 9:41 PM
python_modules/libraries/dagster-k8s/dagster_k8s_tests/utils.py
79–88

khan

This revision was automatically updated to reflect the committed changes.