Page MenuHomePhabricator

remove deprecated ReexecutionConfig
ClosedPublic

Authored by alangenfeld on Jan 16 2020, 4:29 PM.

Details

Summary

byebye

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jan 16 2020, 4:29 PM
max accepted this revision.Jan 16 2020, 5:27 PM
This revision is now accepted and ready to land.Jan 16 2020, 5:27 PM
schrockn accepted this revision.Jan 16 2020, 5:29 PM
schrockn added inline comments.
python_modules/dagster/dagster/core/storage/pipeline_run.py
63

at some point we might want to switch this to protobufs or something to manage backwards/forward compat

prha added a comment.Jan 16 2020, 5:34 PM

the error looks legit... might need to adjust the get_args py27 implementation?

alangenfeld updated this revision to Diff 8741.Jan 16 2020, 5:38 PM

update serdes and seven to better handle py2

alangenfeld updated this revision to Diff 8742.Jan 16 2020, 5:49 PM

rm print()

prha accepted this revision.Jan 16 2020, 6:23 PM
This revision was landed with ongoing or failed builds.Jan 16 2020, 10:02 PM
This revision was automatically updated to reflect the committed changes.