Page MenuHomePhabricator

Improve local test story
ClosedPublic

Authored by max on Jan 16 2020, 3:14 AM.

Details

Summary

It's now possible to test against a preexisting local kind cluster, which brings the cycle time down to ~2 minutes from ~7 minutes or more.

Test Plan

Unit and local unit.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max updated this revision to Diff 8729.Jan 16 2020, 3:14 AM
max created this revision.

Black

alangenfeld accepted this revision.Jan 16 2020, 5:08 PM

nice - just make sure to cleanup unused stuff

python_modules/libraries/dagster-k8s/dagster_k8s/launcher.py
15

rm

This revision is now accepted and ready to land.Jan 16 2020, 5:08 PM
max updated this revision to Diff 8743.Jan 16 2020, 5:53 PM

Fixup

This revision was automatically updated to reflect the committed changes.
alangenfeld added inline comments.Jan 17 2020, 11:45 PM
python_modules/libraries/dagster-k8s/helm/dagster/values.yaml
11–13

i think we probably want to go back to this model for usability - its nice to be able to just override a tag