Page MenuHomePhabricator

[celery] emit engine event on failed broker connection
ClosedPublic

Authored by alangenfeld on Jan 15 2020, 9:59 PM.

Details

Summary

improve the experience if you do celery execution but can not connect to the broker

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jan 15 2020, 9:59 PM
alangenfeld added inline comments.Jan 15 2020, 10:05 PM
python_modules/dagster-celery/dagster_celery/config.py
15–18

arbitrary - happy to change these if someone has an opinion

max accepted this revision.Jan 16 2020, 4:15 AM
max added inline comments.
python_modules/dagster-celery/dagster_celery/config.py
15–18

let's add a comment that these are just guesses

This revision is now accepted and ready to land.Jan 16 2020, 4:15 AM