Page MenuHomePhabricator

[dagster-postgres] update config to Selector
ClosedPublic

Authored by alangenfeld on Jan 13 2020, 6:35 PM.

Details

Summary

This allows moving connection string contruction to code for things like our helm charts and allows us to url quote passwords that may contain characters that need to be escaped

Test Plan

added test cases

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jan 13 2020, 6:35 PM
alangenfeld updated this revision to Diff 8654.Jan 13 2020, 7:18 PM

use conn_string to get DB fixture

schrockn accepted this revision.Jan 13 2020, 7:22 PM

๐Ÿ‘๐Ÿป

This revision is now accepted and ready to land.Jan 13 2020, 7:22 PM
alangenfeld updated this revision to Diff 8655.Jan 13 2020, 7:24 PM

use correct fixture

This revision was automatically updated to reflect the committed changes.