Page MenuHomePhabricator

More clear name properties for config types and graphql scalar union support
ClosedPublic

Authored by schrockn on Jan 13 2020, 4:51 PM.

Details

Summary

This PR buckets up three changes:

  1. In the GraphQL schema for config types we rename name to givenName,

make it non-nullable, and move it to the only two subtypes that have
given names, enums and "regular" types.

  1. Flow Scalar Union down to GraphQL and render them in the config

editor. Typeahead still does not work

  1. Makes the input hydration config just a dictionary with "value",

"json", and "pickle" keys rather than a scalar union, which in the
case of Any was an ambiguous parse.

Test Plan

BK. Use config editor. See attached screenshot.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn retitled this revision from graphql config type updates to More clear name properties for config types and graphql scalar union support.
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: prha, alangenfeld.

upmessage

schrockn edited the summary of this revision. (Show Details)

upmessage

This all makes sense to me.... letting @alangenfeld take a look

This revision is now accepted and ready to land.Jan 14 2020, 9:19 PM