Page MenuHomePhabricator

(new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors
ClosedPublic

Authored by schrockn on Sun, Jan 12, 5:53 PM.

Details

Summary

First just eliminate the API to specify name on a Selector or
a Shape.

Then name to "given_name". It is only valid for scalars and enums. No other types are given names.

Depends on D1823

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Sun, Jan 12, 5:53 PM
schrockn updated this revision to Diff 8621.Sun, Jan 12, 6:23 PM

upmessage

schrockn updated this revision to Diff 8622.Sun, Jan 12, 9:21 PM
schrockn retitled this revision from Killing config name to (new-types-package-org-4) Make name more clear. Eliminate named dicts and selectors.
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: alangenfeld, max.

upmessage

alangenfeld accepted this revision.Mon, Jan 13, 4:26 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/config/field_utils.py
57–67

byebye

This revision is now accepted and ready to land.Mon, Jan 13, 4:26 PM