Page MenuHomePhabricator

(new-types-package-org-1) dagster.core.types.config --> dagster.config
ClosedPublic

Authored by schrockn on Jan 11 2020, 1:04 PM.

Details

Summary

This PR makes our config system a top-level subpackage
and a peer to check. This makes the layering much more clear. Eventually
I want to never talk about "config types" and "runtime types" ever
again. Instead we'll have the "config system" (which could end up
being its own standalone module) and the "dagster types". We shall see
though.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
config-top-level-subpackage
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Jan 11 2020, 1:04 PM
schrockn updated this revision to Diff 8616.Jan 11 2020, 1:24 PM
schrockn retitled this revision from config to top-level subpackage to (new-types-package-org-1) dagster.core.types.config --> dagster.config.
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

This revision is now accepted and ready to land.Jan 13 2020, 4:16 PM