Page MenuHomeElementl

(dict-where-type-is-used-9) Optional --> Noneable
ClosedPublic

Authored by schrockn on Jan 9 2020, 8:39 PM.

Details

Summary

This renames the config notion of Nullability to "Noneable"
to disambiguate from Optional.

Depends on D1807

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also could do Noneable which is cute

schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: alangenfeld, max.

upmessage

is Nullable going to trip up newish python only users up since there is no notion of null ? I think Noneable is worth discussing. Going to leave this one open for more debate

There is some potential for confusion with both Noneable and Nullable if these are meant to imply that a value can be omitted (vs. explicitly set to Python None or to YAML/JSON null). I kind of like the way that Noneable fails to jibe with ordinary language, it's like Shape in this respect -- it indicates that you're doing something a little out of the ordinary, you should pay attention.

This is not omission (that is is_optional on Field). This is whether the value can be None

This comment was removed by max.

ah great. I vote for Noneable

those all sound like omission to me

schrockn retitled this revision from (dict-where-type-is-used-9) Optional --> Nullable to (dict-where-type-is-used-9) Optional --> Noneable.
schrockn edited the summary of this revision. (Show Details)

upmessage

This revision is now accepted and ready to land.Jan 10 2020, 11:50 PM