Page MenuHomePhabricator

(dict-where-type-is-used-9) Optional --> Noneable
ClosedPublic

Authored by schrockn on Jan 9 2020, 8:39 PM.

Details

Summary

This renames the config notion of Nullability to "Noneable"
to disambiguate from Optional.

Depends on D1807

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Jan 9 2020, 8:39 PM

Also could do Noneable which is cute

schrockn updated this revision to Diff 8525.Jan 9 2020, 8:55 PM
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: alangenfeld, max.

upmessage

alangenfeld added a comment.EditedJan 9 2020, 10:56 PM

is Nullable going to trip up newish python only users up since there is no notion of null ? I think Noneable is worth discussing. Going to leave this one open for more debate

max added a comment.EditedJan 9 2020, 11:16 PM

There is some potential for confusion with both Noneable and Nullable if these are meant to imply that a value can be omitted (vs. explicitly set to Python None or to YAML/JSON null). I kind of like the way that Noneable fails to jibe with ordinary language, it's like Shape in this respect -- it indicates that you're doing something a little out of the ordinary, you should pay attention.

max added a comment.Jan 9 2020, 11:16 PM

Omittable?

This is not omission (that is is_optional on Field). This is whether the value can be None

max added a comment.Jan 9 2020, 11:20 PM
This comment was removed by max.
max added a comment.Jan 9 2020, 11:20 PM

ah great. I vote for Noneable

those all sound like omission to me

schrockn updated this revision to Diff 8572.Jan 10 2020, 12:16 AM

Nullable --> Noneable

schrockn updated this revision to Diff 8573.Jan 10 2020, 12:20 AM
schrockn retitled this revision from (dict-where-type-is-used-9) Optional --> Nullable to (dict-where-type-is-used-9) Optional --> Noneable.
schrockn edited the summary of this revision. (Show Details)

upmessage

max accepted this revision.Jan 10 2020, 11:50 PM
This revision is now accepted and ready to land.Jan 10 2020, 11:50 PM
This revision was automatically updated to reflect the committed changes.