Page MenuHomePhabricator

(dict-where-type-is-used-8) Shape --> Dict
ClosedPublic

Authored by schrockn on Thu, Jan 9, 4:47 PM.

Details

Summary

This is what the proposed change from Dict to Shape look like.
Again the new condensed syntax will significantly limit the impact of
this IMO

Depends on D1806

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Thu, Jan 9, 4:47 PM
Harbormaster failed remote builds in B6906: Diff 8503!
Harbormaster failed remote builds in B6911: Diff 8508!
schrockn updated this revision to Diff 8510.Thu, Jan 9, 5:18 PM
schrockn retitled this revision from Shape --> Dict to (dict-where-type-is-used-8) Shape --> Dict.
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

schrockn updated this revision to Diff 8511.Thu, Jan 9, 5:29 PM

elim more shapes

Harbormaster completed remote builds in B6915: Diff 8512.
alangenfeld accepted this revision.Thu, Jan 9, 10:54 PM

im down - I'll go ahead and accept but probably worth double checking with @max if you want more thoughts

This revision is now accepted and ready to land.Thu, Jan 9, 10:54 PM
This revision was automatically updated to reflect the committed changes.