Page MenuHomePhabricator

(dict-where-type-is-used-5) Rename Config List to Array
ClosedPublic

Authored by schrockn on Jan 9 2020, 1:53 PM.

Details

Summary

With the change to allow bare python lists to specify config
schema, I'm far more comfortable with this rename. This is what it looks
like.

I think this is a pretty big win even though it is breaking change. The
"fix" is really quite simple. Where you used List[something] in a config
you can now just say [something].

Depends on D1803

Test Plan

test

Diff Detail

Repository
R1 dagster
Branch
dict-where-type-is-used-5
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Jan 9 2020, 1:53 PM
schrockn updated this revision to Diff 8499.Jan 9 2020, 2:33 PM
schrockn retitled this revision from (dict-where-type-is-used-5) List to array to (dict-where-type-is-used-5) Rename Config List to Array.
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: max, alangenfeld.

upmessage

alangenfeld accepted this revision.Jan 9 2020, 10:46 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/types/config/field.py
80

Please use a python list

similar to other diffs an example or further clarification on how to use python list

python_modules/dagster/dagster/core/types/runtime/config_schema.py
35–36

cleanup

This revision is now accepted and ready to land.Jan 9 2020, 10:46 PM
This revision was automatically updated to reflect the committed changes.