Page MenuHomePhabricator

Run tests locally (OS X)
ClosedPublic

Authored by max on Jan 8 2020, 11:39 PM.

Details

Summary

It's very desirable that our k8s tests be able to run on OS X for local dev.

Test Plan

Unit (local & buildkite)

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Jan 8 2020, 11:39 PM
schrockn accepted this revision.Jan 8 2020, 11:57 PM

thank you for doing this. my comments are mostly about what was there before

python_modules/libraries/dagster-k8s/dagster_k8s_tests/conftest.py
21

pretty confused why we are using fixtures for stuff like this rather than bare functions

95

sidenote: this dag of fixtures is kind of crazypants

96

is there no way to thread through this value to the underling library so we don't have to rely on environment variables?

This revision is now accepted and ready to land.Jan 8 2020, 11:57 PM
max updated this revision to Diff 8540.Jan 9 2020, 10:13 PM

Fixup

This revision was landed with ongoing or failed builds.Jan 11 2020, 1:44 AM
Closed by commit R1:d48a24b0853c: Run tests locally (OS X) (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.