Page MenuHomePhabricator

[RFC] Eliminate get_runs_with... methods on RunStorage and DagsterInstance
ClosedPublic

Authored by sashank on Jan 8 2020, 12:44 AM.

Details

Summary

With the introduction of the get_runs and get_runs_count methods, we can consolidate all of the get_runs_with... and get_runs_count_with... methods that exist on RunStorage. This diff deletes all of the get_runs_with... and get_runs_count_with... methods and replaces calls to them with calls to get_runs` and get_runs_count with the appropriate filters.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Jan 8 2020, 12:44 AM
sashank updated this revision to Diff 8458.Jan 8 2020, 7:11 PM

Another rebase

sashank edited the summary of this revision. (Show Details)Jan 8 2020, 8:07 PM
sashank added reviewers: prha, alangenfeld.
sashank updated this revision to Diff 8476.Jan 8 2020, 9:51 PM
sashank edited the summary of this revision. (Show Details)

Rebase to fix postgres tests

intense-nod

python_modules/dagster/dagster/core/storage/runs/base.py
59–106

burn-it-down

This revision is now accepted and ready to land.Jan 8 2020, 11:10 PM
sashank updated this revision to Diff 8484.Jan 9 2020, 12:17 AM

Also eliminate all_runs :)