Page MenuHomePhabricator

add timeout to RemoteDagitRunLauncher
ClosedPublic

Authored by alangenfeld on Mon, Jan 6, 9:56 PM.

Details

Test Plan

Set run launcher address to a bad url - verify launch attempt times out instead of hanging indefinitely

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld updated this revision to Diff 8378.Mon, Jan 6, 9:56 PM
alangenfeld created this revision.

rebase

prha added inline comments.Mon, Jan 6, 10:57 PM
python_modules/dagster/dagster/core/serdes/__init__.py
200

where is the difference between process_config and validate_config material?

alangenfeld added inline comments.Tue, Jan 7, 4:05 PM
python_modules/dagster/dagster/core/serdes/__init__.py
200

applying default values

This revision is now accepted and ready to land.Tue, Jan 7, 4:27 PM
This revision was automatically updated to reflect the committed changes.