Page MenuHomePhabricator

handle python 2.7 in seven.get_args
ClosedPublic

Authored by prha on Mon, Jan 6, 7:09 PM.

Details

Summary

Initially encountered this in D1777, but different enough to pull out as a separate diff

Test Plan

ran seven tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Mon, Jan 6, 7:09 PM
alangenfeld added inline comments.Mon, Jan 6, 10:02 PM
python_modules/dagster/dagster/seven/__init__.py
127

huh how did this work before if we are doing .args now?

alangenfeld accepted this revision.Mon, Jan 6, 10:02 PM

in tests we trust

yaytests

This revision is now accepted and ready to land.Mon, Jan 6, 10:02 PM
prha added inline comments.Mon, Jan 6, 10:08 PM
python_modules/dagster/dagster/seven/__init__.py
127

I think it wasn't working :/

There's currently only one call-site, using serdes for the deserialization of classes

127

Also, it wouldn't error out, it would just ignore the serialized properties.

This revision was landed with ongoing or failed builds.Mon, Jan 6, 10:10 PM
This revision was automatically updated to reflect the committed changes.