Page MenuHomePhabricator

Only get DAGSTER_DOCKER_IMAGE on demand rather than at include time
ClosedPublic

Authored by schrockn on Dec 30 2019, 8:36 PM.

Details

Summary

This allows one to at least run unit tests that don't require external resources

Tracking this here https://github.com/dagster-io/dagster/issues/2041

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 30 2019, 8:36 PM
schrockn updated this revision to Diff 8272.Dec 30 2019, 8:53 PM

upmessage

schrockn updated this revision to Diff 8273.Dec 30 2019, 8:59 PM

upmessage

nate accepted this revision.Dec 30 2019, 9:00 PM
nate added inline comments.
python_modules/dagster-airflow/dagster_airflow/test_fixtures.py
124

remove commented line?

This revision is now accepted and ready to land.Dec 30 2019, 9:00 PM
schrockn updated this revision to Diff 8274.Dec 30 2019, 9:08 PM
schrockn edited the summary of this revision. (Show Details)

upmessage

schrockn updated this revision to Diff 8276.Dec 30 2019, 9:22 PM

upmessage