Page MenuHomePhabricator

Cleaner Buildkite tox logging
ClosedPublic

Authored by nate on Dec 30 2019, 7:16 PM.

Details

Summary

This hides a couple hundred lines of test setup logging, to make it easier to quickly jump right to pytest output in buildkite logs:

in this example, log lines 124-402 are hidden by default

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Dec 30 2019, 7:16 PM
nate edited the summary of this revision. (Show Details)Dec 30 2019, 7:27 PM
nate added a reviewer: schrockn.
nate edited the summary of this revision. (Show Details)
nate updated this revision to Diff 8262.Dec 30 2019, 7:35 PM

a few more

schrockn added inline comments.Dec 30 2019, 7:45 PM
python_modules/dagster-graphql/tox.ini
21

so these magic characters make collapse-able sections in bk?

nate added inline comments.Dec 30 2019, 8:21 PM
python_modules/dagster-graphql/tox.ini
21

yep, any log line that starts with "---" creates a section.

The rest of this is (1) to color the text green, and (2) BK supports custom emoji for pytest, docker, k8s, etc. here: https://github.com/buildkite/emojis

schrockn accepted this revision.Dec 30 2019, 11:07 PM

Ok. We *really* need to get these tox.ini controlled by tooling

This revision is now accepted and ready to land.Dec 30 2019, 11:07 PM
This revision was automatically updated to reflect the committed changes.