Page MenuHomePhabricator

(scalars-unions-1) Eliminiate all kind-related helper methods on ConfigType
ClosedPublic

Authored by schrockn on Dec 21 2019, 7:00 PM.

Details

Summary

Just use enum directly. Less surface area and no tempetation to do
this via subclassing

Depends on D1733

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 21 2019, 7:00 PM
schrockn updated this revision to Diff 8264.Dec 30 2019, 7:54 PM
schrockn added reviewers: max, alangenfeld.

upmessage

schrockn updated this revision to Diff 8285.Dec 30 2019, 9:38 PM

upmessage

alangenfeld accepted this revision.Jan 2 2020, 6:36 PM

whynot

python_modules/dagster/dagster/core/types/config/config_type.py
116–119

clean up

This revision is now accepted and ready to land.Jan 2 2020, 6:36 PM