Page MenuHomePhabricator

(scalar-unions-0) Delete debug_str
ClosedPublic

Authored by schrockn on Dec 21 2019, 6:30 PM.

Details

Summary

This appears to be unused. It adds surface area that needs to
be changed when we modify the type system and I would rather not have to
maintain it

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 21 2019, 6:30 PM
schrockn updated this revision to Diff 8263.Dec 30 2019, 7:51 PM
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: sashank, alangenfeld.

upmessage

schrockn updated this revision to Diff 8265.Dec 30 2019, 7:54 PM
schrockn added a reviewer: max.

upmessage

schrockn updated this revision to Diff 8284.Dec 30 2019, 9:37 PM

upmessage

I'm not opposed to keeping just we should figure out a spot to use it if we do

alangenfeld accepted this revision.Jan 2 2020, 4:46 PM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Jan 2 2020, 4:46 PM
sashank added a comment.EditedJan 2 2020, 11:34 PM

Feel free to delete. For context, we added this to help during debugging – it was difficult to inspect config fields and types in pdb, and running config_type.debug_str() was easier than manually drilling down.

schrockn updated this revision to Diff 8387.Jan 6 2020, 10:29 PM

nbformat

This revision was landed with ongoing or failed builds.Jan 6 2020, 10:58 PM
This revision was automatically updated to reflect the committed changes.