Page MenuHomePhabricator

Remove step_metadata_fn

Authored by alangenfeld on Dec 20 2019, 9:55 PM.



All I want for Xmas (stacked on 1729)

Test Plan


Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Dec 20 2019, 9:55 PM
max edited the summary of this revision. (Show Details)Dec 20 2019, 10:00 PM

does the metadata field on the solid not end up in the same place? I was expecting some code to migrated to that in order to drop this

alangenfeld requested changes to this revision.Dec 20 2019, 10:28 PM

I think we refer to this in the dask docs at least so that will need to get updated as well. My assumption is that we can accomplish the same thing with the metadata field on solid (maybe by passing it along to the execution steps)

This revision now requires changes to proceed.Dec 20 2019, 10:28 PM
alangenfeld commandeered this revision.Jan 28 2020, 6:33 PM
alangenfeld edited reviewers, added: max; removed: alangenfeld.
This revision now requires review to proceed.Jan 28 2020, 6:33 PM
alangenfeld updated this revision to Diff 9095.Jan 29 2020, 6:03 PM

rebase +

max accepted this revision.Jan 29 2020, 11:01 PM
This revision is now accepted and ready to land.Jan 29 2020, 11:01 PM
This revision was automatically updated to reflect the committed changes.