Page MenuHomePhabricator

Remove step_metadata_fn
Needs RevisionPublic

Authored by max on Dec 20 2019, 9:55 PM.

Details

Reviewers
alangenfeld
nate
Summary

All I want for Xmas (stacked on 1729)

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
rm-step-metadata-fn
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Dec 20 2019, 9:55 PM
max edited the summary of this revision. (Show Details)Dec 20 2019, 10:00 PM

does the metadata field on the solid not end up in the same place? I was expecting some code to migrated to that in order to drop this

alangenfeld requested changes to this revision.Dec 20 2019, 10:28 PM

I think we refer to this in the dask docs at least so that will need to get updated as well. My assumption is that we can accomplish the same thing with the metadata field on solid (maybe by passing it along to the execution steps)

This revision now requires changes to proceed.Dec 20 2019, 10:28 PM