Page MenuHomePhabricator

Parameterize event storage tests
ClosedPublic

Authored by sashank on Dec 20 2019, 6:40 PM.

Details

Summary

We previously duplicated tests for the in-memory and sqlite implementations of event log storage.

This diff simply uses the pytest parameterize feature to consolidate the duplicate tests.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

verygood

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_event_log.py
38–46

you could probably structure this so that the event_storage_test decorator does the with for you but and just passes the instance of the event log storage

This revision is now accepted and ready to land.Dec 20 2019, 7:23 PM
sashank edited the summary of this revision. (Show Details)

Add test for fix in D1726