Page MenuHomePhabricator

Reinstate WAL in sqlite storages

Authored by max on Dec 19 2019, 7:47 PM.



We missed this when we migrated to SQLAlchemy; empirically it seems to be the source of issues with concurrent writes and DB locking.

Test Plan

Manual, pragma

Diff Detail

R1 dagster
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Dec 19 2019, 7:47 PM
alangenfeld accepted this revision.Dec 19 2019, 8:09 PM

should we do any isolation level tweaking?

This revision is now accepted and ready to land.Dec 19 2019, 8:09 PM
This revision was automatically updated to reflect the committed changes.
max added a comment.Dec 19 2019, 9:41 PM

i played with the isolation level a little bit but couldn't identify an impact