Page MenuHomePhabricator

Reinstate WAL in sqlite storages
ClosedPublic

Authored by max on Dec 19 2019, 7:47 PM.

Details

Summary

We missed this when we migrated to SQLAlchemy; empirically it seems to be the source of issues with concurrent writes and DB locking.

Test Plan

Manual, pragma

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Dec 19 2019, 7:47 PM
alangenfeld accepted this revision.Dec 19 2019, 8:09 PM

should we do any isolation level tweaking?

This revision is now accepted and ready to land.Dec 19 2019, 8:09 PM
max added a comment.Dec 19 2019, 9:41 PM

i played with the isolation level a little bit but couldn't identify an impact