Page MenuHomePhabricator

Add missing where clause to event storage
ClosedPublic

Authored by sashank on Dec 19 2019, 6:09 AM.

Details

Summary

When using PostgresEventLogStorage, we would see incorrect stats for runs. This diff adds a simple where clause to the query in SqlEventLogStorage.get_stats_for_run.

We didn't see this issue with SqliteEventLogStorage because we shard the sqlite files by run_id, so this where clause is not necessary in the sqlite case.

https://github.com/dagster-io/dagster/issues/2009

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.