Page MenuHomePhabricator

Fixes for Postgres-backed storage performance
ClosedPublic

Authored by max on Dec 17 2019, 10:07 PM.

Details

Summary

We were previously leaking Postgres connection pools, which is an issue in cases where we
are spinning up many instances (like Celery execution).

Test Plan

Manual

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Dec 17 2019, 10:07 PM
max updated this revision to Diff 7902.Dec 17 2019, 10:47 PM

Rebase

max added a reviewer: prha.Dec 17 2019, 10:51 PM
Harbormaster completed remote builds in B6394: Diff 7903.
prha added inline comments.Dec 17 2019, 11:13 PM
python_modules/libraries/dagster-postgres/dagster_postgres/run_storage/run_storage.py
25

should these args be used?

prha accepted this revision.Dec 18 2019, 12:39 AM
This revision is now accepted and ready to land.Dec 18 2019, 12:39 AM
This revision was automatically updated to reflect the committed changes.