Page MenuHomePhabricator

(new-config-parsing-8) Rename apply_default_values to post_process_config
ClosedPublic

Authored by schrockn on Dec 16 2019, 3:59 AM.

Details

Summary

This is a more accurate name to take into account post-processing
of enums and other upcoming features.

Depends on D1673

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn updated this revision to Diff 7784.Dec 16 2019, 3:59 AM
schrockn created this revision.

up

Harbormaster completed remote builds in B6297: Diff 7784.
alangenfeld accepted this revision.Dec 16 2019, 5:40 PM

certainly an improvement over apply_default_values

python_modules/dagster/dagster/core/types/config/evaluator/validate.py
292–297

re: names - process calling post_process is a little odd. Not blocking but worth another few minutes of pondering better names

This revision is now accepted and ready to land.Dec 16 2019, 5:40 PM