Page MenuHomePhabricator

(new-config-parsing-5) TraversalContext --> ValidationContext
ClosedPublic

Authored by schrockn on Dec 15 2019, 7:38 PM.

Details

Summary

And extract config_value out of ValidationContext.

This was odd to model in one's head IMO as the thing being operated
on was different than the context. The config value gets mutated
and the other items did not so this seems like a natural division

Depends on D1669

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 15 2019, 7:38 PM
nate accepted this revision.Dec 16 2019, 4:39 PM

lgtm! see one comment

python_modules/dagster/dagster/core/types/config/evaluator/validate.py
191

seeing this w/ fresh eyes, does this need to be a deepcopy? for nested values?

This revision is now accepted and ready to land.Dec 16 2019, 4:39 PM
schrockn added inline comments.Dec 16 2019, 4:40 PM
python_modules/dagster/dagster/core/types/config/evaluator/validate.py
191

nope. top-level copy sufficent. later in this stack this goes away entirely