Page MenuHomePhabricator

(new-config-parsing-3) innerTypes --> recursiveConfigTypes
ClosedPublic

Authored by schrockn on Dec 15 2019, 6:46 PM.

Details

Summary

Renaming this to indicate it's perniciousness. It recursively
fetches all the config types that it refers to. This can be very expensive

Depends on D1665

Test Plan

BK & load dagit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 15 2019, 6:46 PM
schrockn updated this revision to Diff 7764.Dec 15 2019, 7:00 PM
schrockn edited the summary of this revision. (Show Details)
schrockn added a parent revision: D1661: Pin coverage to 4.5.4.

upmessage

schrockn updated this revision to Diff 7765.Dec 15 2019, 7:10 PM

upmessage

Harbormaster completed remote builds in B6281: Diff 7767.
bengotow accepted this revision.Dec 15 2019, 9:40 PM

Good call—I think this naming is much more clear.

This revision is now accepted and ready to land.Dec 15 2019, 9:40 PM