Page MenuHomePhabricator

(new-config-parsing-2) Delete configTypeOrError
ClosedPublic

Authored by schrockn on Dec 14 2019, 10:30 PM.

Details

Summary

We used to be able to fetch individual config types by name.

Given that we are moving to a world where most types are just anonymous
entries in a single schema it no longer makes sense to fetch by config
type name.

Depends on D1649

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 14 2019, 10:30 PM
schrockn updated this revision to Diff 7753.Dec 14 2019, 10:44 PM
schrockn retitled this revision from delete config type or error to Delete configTypeOrError.
schrockn edited the summary of this revision. (Show Details)
schrockn edited the test plan for this revision. (Show Details)

upmessage

schrockn updated this revision to Diff 7759.Dec 15 2019, 6:31 PM
schrockn retitled this revision from Delete configTypeOrError to (new-config-parsing-2) Delete configTypeOrError.
schrockn added reviewers: nate, alangenfeld.

upmessage

schrockn updated this revision to Diff 7763.Dec 15 2019, 6:58 PM
schrockn edited the summary of this revision. (Show Details)

upmessage

nate accepted this revision.Dec 16 2019, 4:35 PM
This revision is now accepted and ready to land.Dec 16 2019, 4:35 PM
This revision was automatically updated to reflect the committed changes.