Page MenuHomePhabricator

(more-config-work-7) All scalars in all config spots
ClosedPublic

Authored by schrockn on Dec 11 2019, 9:14 PM.

Details

Summary

Had to do some sketchy stuff to allow @resource and @logger
to accept bare types in their config argument. The problem is that
config is the first argument and we detect the case where the
decorator is called *without* parens by seeing if the first
argument is callable. However if you pass in something like
int that itself is callable. That ends up failing.

So instead we check to see if this are valid and callable first.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 11 2019, 9:14 PM
schrockn updated this revision to Diff 7593.Dec 11 2019, 9:32 PM
schrockn retitled this revision from All scalars in all config spots to (more-config-work-7) All scalars in all config spots.
schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: max, alangenfeld, nate.

upmessage

max accepted this revision.Dec 11 2019, 10:01 PM
This revision is now accepted and ready to land.Dec 11 2019, 10:01 PM
This revision was automatically updated to reflect the committed changes.