Page MenuHomePhabricator

(python-typing-to-inference-7-rebase-off-of-5) Transform typing to wrapping types at the top of resolve_to_runtime_type and rip typing checks out of the core
ClosedPublic

Authored by schrockn on Dec 9 2019, 9:39 PM.

Details

Summary

This simplifies and clarifies these code paths considerably

Depends on D1577

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Dec 9 2019, 9:39 PM
schrockn updated this revision to Diff 7333.Dec 9 2019, 9:42 PM
schrockn added reviewers: max, alangenfeld.

upmessage

Note this is the version that does *not* disallow typing.* types as the Input/OutputDefinition layer

schrockn retitled this revision from (python-typing-to-inference-7) Transform typing to wrapping types at the top of resolve_to_runtime_type and rip typing checks out of the core to (python-typing-to-inference-7-rebase-off-of-5) Transform typing to wrapping types at the top of resolve_to_runtime_type and rip typing checks out of the core.Dec 9 2019, 9:43 PM
schrockn updated this revision to Diff 7335.Dec 9 2019, 9:49 PM

upmessage

This revision is now accepted and ready to land.Dec 10 2019, 12:09 AM
This revision was landed with ongoing or failed builds.Dec 10 2019, 12:26 AM
This revision was automatically updated to reflect the committed changes.