Page MenuHomePhabricator

(python-config-type-instance-20) Make OutputMaterializationConfig and InputHydrationConfig subclasses vanilla objects
ClosedPublic

Authored by schrockn on Dec 7 2019, 9:37 PM.

Details

Summary

These were also using a dynamic class pattern, and for no good reason as far as I can tell. Just make them act like normal objects.

Depends on D1597

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
python-config-type-instance-19
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

schrockn created this revision.Dec 7 2019, 9:37 PM
schrockn updated this revision to Diff 7421.Dec 10 2019, 1:54 AM
schrockn retitled this revision from (python-config-type-instance-19) Make OutputMaterializationConfig and InputHydrationConfig subclasses vanilla objects to (python-config-type-instance-20) Make OutputMaterializationConfig and InputHydrationConfig subclasses vanilla objects.

upmessage

This revision is now accepted and ready to land.Dec 10 2019, 2:14 AM